Implement support for VCF 452 APIs #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update is required as new APIs for rotation of certificate from external CA have been included in the 452 release, that the VCF provider needs to make use of. Reverted manually changes to ResourcePoolSpec and SDDCNSXTSpec, changed in previous commits. Testing done: go mod tidy go build Signed-off-by: Dimitar Proynov <proynovd@vmware.com>
Testing done: go mod tidy go build Signed-off-by: Dimitar Proynov <proynovd@vmware.com>
raj-chelur
approved these changes
Oct 17, 2023
|
Yes. Please change it to 4.5.2.
…On Wed, Oct 18, 2023 at 9:16 AM Dimitar Proynov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In swagger.json
<#21 (comment)>:
> @@ -2,7 +2,7 @@
"swagger" : "2.0",
"info" : {
"description" : "VMware Cloud Foundation is an integrated software stack that bundles the VMware virtualization and management components like compute virtualization (vSphere), storage virtualization (vSAN), network virtualization (NSX), and cloud management (vRealize Suite). VCF consists of Cloud Builder - that automates the bringup of the management infrastructure and SDDC Manager - that automates the workload domain management, lifecycle and operations. This API reference guide covers APIs of both Cloud Builder and SDDC Manager",
- "version" : "4.5.0",
+ "version" : "4.5.2-vcf4520RELEASE",
It came from the recommended build (the same for some mouths now) from
vcf4520. Maybe I should leave "4.5.2" only?
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBQLG5KGUSGGAMGOCLZLBTX77JBZAVCNFSM6AAAAAA6D6R422VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBVGA2TEOJTGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Testing done: go mod tidy go build Signed-off-by: Dimitar Proynov <proynovd@vmware.com>
dimitarproynov
dismissed stale reviews from tenthirtyam and vasilsatanasov
via
f0267b9
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update is required as new APIs for rotation of certificate from external CA have been included in the 452 release, that the VCF provider needs to make use of.
Reverted manually changes to ResourcePoolSpec and SDDCNSXTSpec, changed in previous commits.
In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.
Summary of Pull Request
Implement support for VCF 452 APIs
Type of Pull Request
Please describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
Testing done:
go mod tidy
go build
For bug fixes or features:
Breaking Changes?